Add enum and number values support to JsonKeysetCursorStrategy #1346
+64
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Bakaev <stupid58fly@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
|
Hello @stupid58fly We're considering both this issue and #1347. Could you first elaborate a bit on the exact problem you're seeing? How do your entities/repositories/data fetchers look like in your code and what error are you hitting exactly? We don't need a complete analysis of the problem, but rather a short sample or anything that can help us better understand the use case would be welcome. |
bclozel
added
the
status: waiting-for-feedback
i have @Entity
@Table(name = "product")
public class Product {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;
@Column(nullable = false)
private String name;
@Column(nullable = false)
private BigDecimal cost;
}public interface ProductRepository extends JpaRepository<Product, Long> {
Window<Product> findByIdIsNotNull(ScrollPosition position, Sort sort, Limit limit);
}@Controller
@RequiredArgsConstructor
public class ProductController {
private final ProductRepository productRepository;
@QueryMapping
public Window<Product> products(ScrollSubrange scrollSubrange) {
var position = scrollSubrange.position().orElseGet(ScrollPosition::keyset);
var sort = Sort.by(Sort.Direction.ASC, "cost");
var limit = scrollSubrange.count().stream().boxed().findFirst().map(Limit::of).orElseGet(Limit::unlimited);
return productRepository.findByIdIsNotNull(position, sort, limit);
}
}when i try to fetch products without parameters, all is ok query MyQuery {
products (
after: "S19bImphdmEudXRpbC5Db2xsZWN0aW9ucyRVbm1vZGlmaWFibGVNYXAiLHsiaWQiOlsiamF2YS5sYW5nLkxvbmciLDIwXSwiY29zdCI6WyJqYXZhLm1hdGguQmlnRGVjaW1hbCIsMC4wMF19XQ=="
first: 10
) {
pageInfo {
endCursor
hasNextPage
hasPreviousPage
startCursor
}
edges {
cursor
node {
cost
id
name
}
}
}
}and this PR will fix the issue with deserialization for number (long, big decimal, etc) and enums the issue #1347 is aimed for a more general fix, i.e. for |
spring-projects-issues
added
status: feedback-provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same issue as at #1327 for enum and numeric values exept integer and double